Deprecated Darkstar fourms

still a duplicate modifier problem here, the modifiers MOD_ENMITY_REDUCTION_PHYSICAL (PLD creed gear) and MOD_ADDITIONAL_EFFECT (sirocco kuk, status bolts, etc.) are both assigned to ID 427 and MOD_PERFECT_COUNTER_ATT (MNK tantra gear) and MOD_ENSPELL_DMG_BONUS (enhancing sword) are both assigned to...

was looking at link's changes to the ai_char_normal and I saw something (that was there already) that didn't look right ///////////////////////////////////////////////////////////////////////// // Start of the attack loop. ///////////////////////////////////////////////////////////////////////// for...

didn't i already do most of those in 4226? the enhancing sword, sirocco kukri and bolts you did do but 4237 broke them also btw the modifiers MOD_ENMITY_REDUCTION_PHYSICAL is already assigned to 427 (which you gave to MOD_ADDITIONAL_EFFECT) and MOD_PERFECT_COUNTER_ATT is already assigned to 428 (yo...

I found a couple more things, these issues were already in the magic.lua before the addeffect changes: the addBonuses and the addBonusesAbility functions both apply the dmgTaken and magicDmgTaken modifiers of the target to the damage. however the finalMagicAdjustments (and now also the finalMagicNon...

well I'll be damned... fuckin se man...

ok you can leave that bit out then

edit: here's the patch without that part
edit2:beat me to it!

I also changed the type casting where the day/weather bonus are being added to prevent unfair penalties due to truncation (i.e. 38+10% = 41 but 38-10%=34) "unfair truncation" is usually how it works on retail yes, the bonuses are still being truncated before being added to the damage, I just change...

I approve thoroughly I fixed a arithmetic mistake you made in HandleEnspell() where the incorrect element # was being passed to the calc function for enlight/dark and tier2 elementals I also changed the type casting where the day/weather bonus are being added to prevent unfair penalties due to trunc...

looking good lotus, did you decide to leave enspell dmg calculation in core or is it just temporary?

wouldn't keeping the additional effects in the core reduce server side load?

I'm not opposed to scripting them I just don't completely understand the motivation

from wiki page on resists: Resisting magic damage causes the target to take 1/2, 1/4, 1/8 of normal damage. If "p" is the percentage of non resisted spells (for example, if 41% of the spells are not resisted, p=0.41), then the distribution of resists might be : 1/2 : p*(1-p), 1/4: p*(1-p)^2, 1/8:(1-...