Page 1 of 1
Crafting guild test items fix
Posted: Tue Sep 03, 2013 9:08 pm
by megazraff
Theres a mis-script in the crafting.lua that doesn't allow anyone to pass level 70 guild test item, fortunately Dickdriver found and fixed it so we can keep on keepin' on with our crafts.
Re: Crafting guild test items fix
Posted: Tue Sep 03, 2013 9:14 pm
by kjLotus
megazraff wrote:Dickdriver
uh... thanks, sir dickdriver..
edit: now that i read this function, i think this is supposed to be the restriction for only having 40 points past 70, but restricting guild test items isn't how it works in retail (meaning your patch isn't really correct)
(Rank < 6 or Rank >= 6) is always true, which kind of makes no sense anyways
Re: Crafting guild test items fix
Posted: Tue Sep 03, 2013 9:37 pm
by maxtherabbit
you are disregarding order of operations
'and' takes precedence over 'or' so its actually
if (rank < 6) or ( (rank>=6) and (hasAlreadyArtisanRank(player,craftID) == 0) )
and i don't care how it works in retail, i fixed the broken ds implementation
eta: yeah the second check on Rank is redundant but hey I didn't write the script, just setting out to unfuck it - you wanna rewrite have at it
Re: Crafting guild test items fix
Posted: Tue Sep 03, 2013 11:38 pm
by kjLotus
wow, so hostile!
maxtherabbit wrote:and i don't care how it works in retail
unfortunately we do, and i can't do anything about that :p
Re: Crafting guild test items fix
Posted: Wed Sep 04, 2013 9:14 am
by maxtherabbit
hostile? you come in here ridiculing my patch because of my character name and a non-retail implementation that I didn't even create not to mention citing a line of code you didn't even read right
check yourself
my goal here was simply to correct the error in the existing implementation which prevents players from progressing, not to completely rebuild the module to meet retail standards
Re: Crafting guild test items fix
Posted: Wed Sep 04, 2013 4:41 pm
by kjLotus
maxtherabbit wrote:you come in here ridiculing my patch because of my character name
actually, i thought your character name was funny, and got a laugh out of it. ridicule? no, just pointing out that i'm not sure that's right. if i were to immediately make a change, i'd just remove the whole check
lighten up man, i'm not here to hate on you or any contributors
Re: Crafting guild test items fix
Posted: Wed Sep 04, 2013 9:43 pm
by megazraff
new patch without the redundant check
edit: fix again to work the way original script was intended to
Re: Crafting guild test items fix
Posted: Thu Sep 05, 2013 12:00 am
by maxtherabbit
oops fixed the fix